-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teams: create the stdenv team #347959
base: master
Are you sure you want to change the base?
teams: create the stdenv team #347959
Conversation
maintainers/team-list.nix
Outdated
@@ -950,6 +950,15 @@ with lib.maintainers; | |||
shortName = "Serokell employees"; | |||
}; | |||
|
|||
stdenv = { | |||
# TODO: https://github.com/NixOS/nixpkgs/issues/347955 | |||
members = [ ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm game to be in it.
Others that I would like in it :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting @emilazy & yourself (@philiptaron) right now along with @reckenrode. Awaiting a response from @Ericson2314 but I am pretty sure he'll want to be on it.
members = [ ]; | ||
scope = "Maintain the standard environment and its surrounding logic."; | ||
shortName = "stdenv"; | ||
enableFeatureFreezePing = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that this will never make much sense. The stdenv changes end up being performed in staging, and roughly ~never make the release notes for a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it just in case 😸, we can always remove it if enough people object.
5ad09dd
to
edc297f
Compare
@@ -27,7 +27,7 @@ | |||
|
|||
# Libraries | |||
/lib @infinisil | |||
/lib/systems @alyssais @ericson2314 | |||
/lib/systems @alyssais @ericson2314 @NixOS/stdenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @alyssais @Ericson2314 on this one. Is it redundant to have a member of the stdenv team mentioned while also mentioning the stdenv team itself?
/pkgs/stdenv @philiptaron @NixOS/stdenv | ||
/pkgs/stdenv/generic @Ericson2314 @NixOS/stdenv | ||
/pkgs/stdenv/generic/check-meta.nix @Ericson2314 @NixOS/stdenv | ||
/pkgs/stdenv/cross @Ericson2314 @NixOS/stdenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this, @philiptaron & @Ericson2314, do we want to mention members of the team, just the team, or both (leave as is)?
edc297f
to
13dfe62
Compare
Things done
Re: #347955
Please add a review to suggest who to add into the stdenv team. Once this PR is done, a team on GitHub will be created and the members listed in this PR will be added.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.